Rockset migration - move upload for queue_times_historical from rockset to s3 #5398
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
facebook-github-bot
added
the
CLA Signed
huydhn
reviewed
Jul 4, 2024
| @@ -48,6 +48,7 @@ SELECT | |||
| COUNT(*) AS count, | |||
| MAX(queue_s) AS avg_queue_s, | |||
| machine_type, | |||
| CURRENT_TIMESTAMP() AS _event_time | |||
There was a problem hiding this comment.
Maybe a comment on why we need to use CURRENT_TIMESTAMP as _event_time here. I guess that this is because Rockset uses the time when it ingests the data as _event_time. So, re-importing records from S3 will set them all to the same _event_time?
There was a problem hiding this comment.
Yes _event_time is the time records get added to rockset if it is empty https://docs.rockset.com/documentation/docs/special-fields#the-_event_time-field
I decided to make a different field entirely so theres less confusion between the two
huydhn
reviewed
Jul 4, 2024
huydhn
approved these changes
Jul 4, 2024
clee2000
added a commit
that referenced
this pull request
Jul 9, 2024
…low (#5411) Role defined in pytorch-labs/pytorch-gha-infra#441 Related * #5398
clee2000
added a commit
that referenced
this pull request
Jul 9, 2024
…ield instead of _event_time and fix env variables in update queue times workflow (#5412) Related to #5398 Change historical queue times query for HUD metrics page Looks good <img width="847" alt="image" src="https://github.com/pytorch/test-infra/assets/44682903/3376331c-01f6-45e9-a22c-da359ce6df89"> Also change the workflow so we can use workflow dispatch and so that it has the env vars
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Use the machine type and time as the key